#3315. Add tests for initializer list #3349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Oct 15, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, with a handful of comments.
LanguageFeatures/Declaring-constructors/static_processing_A24_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
Oct 15, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Thank you. Updated. Not all of recommendations implemented as suggested. PTAL.
LanguageFeatures/Declaring-constructors/static_processing_A24_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
eernstg
reviewed
Oct 15, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
I think the treatment of super should indeed be tested, but it doesn't seem to fit into the context where every other test is testing the treatment of an instance variable which is being initialized more than once.
However, don't we already have some tests where the treatment of super is handled? Perhaps there are some missing cases in those tests?
Perhaps it's possible to find a test that tests the treatment of super parameters (no declaring constructors involved at all), and then modify those test cases such that the super parameter is introduced by a primary constructor rather than a regular (non-declaring) one?
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
Oct 15, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Removed superparameters tests. I'll add them in a separate PR (probably as an additional test for superparameters).
LanguageFeatures/Declaring-constructors/static_processing_A24_t03.dart
Outdated
Show resolved
Hide resolved
eernstg
approved these changes
Oct 15, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
LGTM, thanks! Sorry about the nitpicking!
Contributor
Author
No problem at all! Thank you! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 17, 2025
2025-10-16 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for super parameters (dart-lang/co19#3352) 2025-10-16 sgrekhov22@gmail.com dart-lang/co19#3315. Add more declaring constructors tests (dart-lang/co19#3351) 2025-10-15 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for initializer list (dart-lang/co19#3349) 2025-10-15 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for the `new` keyword (dart-lang/co19#3350) 2025-10-14 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for formal parameters. Part 5. (dart-lang/co19#3348) 2025-10-13 sgrekhov22@gmail.com dart-lang/co19#3315. Update assertions. Add test for setters. (dart-lang/co19#3347) 2025-10-10 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for formal parameters. Part 4. (dart-lang/co19#3346) 2025-10-10 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for formal parameters. Part 3. (dart-lang/co19#3345) 2025-10-10 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for formal parameters. Part 2. (dart-lang/co19#3344) R=athom@google.com, eernst@google.com Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: Ie4824457e4c1843e8406dbb7ba8c0a6a10728410 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455600 Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of final variables there is an error that the variable is already initialized and this error may shadow the tested one. But I don't see another way how to test the initializer list behavior.